Skip to content

Support ? Kleene macro operator in 2015 #60932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 9, 2019
Merged

Support ? Kleene macro operator in 2015 #60932

merged 7 commits into from
Jun 9, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 18, 2019 •
edited
Loading

Closes #56668.

See that issue for rationale and discussion.

Crater will be needed (done in #60932 (comment), zero regressions) and then, if all goes well, FCP (in #60932 (comment)).

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2019
@Centril Centril added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels May 18, 2019
@Centril
Copy link
Contributor Author

Centril commented May 18, 2019

@bors try

@bors
Copy link
Collaborator

bors commented May 18, 2019

⌛ Trying commit 695b601 with merge 097e262...

bors added a commit that referenced this pull request May 18, 2019
@bors
Auto merge of #60932 - Centril:macro-at-most-once-2015, r=<try>
097e262 
Support ? Kleene macro operator in 2015

Closes #56668.

See that issue for rationale and discussion.

Crater will be needed and then, if all goes well, FCP.
@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label May 18, 2019
@Centril Centril added this to the 1.37 milestone May 18, 2019
@bors
Copy link
Collaborator

bors commented May 18, 2019

☀️ Try build successful - checks-travis
Build commit: 097e262

@Centril
Copy link
Contributor Author

Centril commented May 18, 2019

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-60932 created and queued.
🤖 Automatically detected try build 097e262
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2019
@craterbot
Copy link
Collaborator

🚧 Experiment pr-60932 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@michaelwoerister
Copy link
Member

r? @nikomatsakis for re-assignment. I don't really know what this is about.

@craterbot
Copy link
Collaborator

🎉 Experiment pr-60932 is completed!
📊 0 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 20, 2019
@Centril
Copy link
Contributor Author

Centril commented May 20, 2019

r? @petrochenkov for actual code review.

@rfcbot merge

Per note in #56668 (comment) we said that we would do this if crater said it didn't break anyone and indeed it does not. Therefore, I propose that we extend support for ? as the Kleene at-most-one macro operator to 2015. The rationale is provided in #56668 (comment). The gist of it is that we want to reduce technical debt in the compiler, the spec, and also reduce edition differences that must be learned. The original stabilization report summarizing the behavior on 2018 can be found in #48075 (comment).

@rfcbot
Copy link
Collaborator

rfcbot commented May 20, 2019 •
edited by nikomatsakis
Loading

Team member @Centril has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 20, 2019
@Centril Centril removed the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label May 20, 2019
@Centril
Copy link
Contributor Author

Centril commented May 20, 2019

N.B. Aaron is on leave so I've checked his box.

@mark-i-m
Copy link
Member

mark-i-m commented Jun 9, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 9, 2019

📌 Commit 1993bef2f440bb656ce9438870cb601ff8865700 has been approved by mark-i-m

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jun 9, 2019
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2019
@bors

This comment has been minimized.

Sign in to view
@Centril Centril force-pushed the macro-at-most-once-2015 branch from 1993bef to 3ba82f7 Compare June 9, 2019 03:00
@Centril
Copy link
Contributor Author

Centril commented Jun 9, 2019

...rebased

@bors r=mark-i-m

@bors
Copy link
Collaborator

bors commented Jun 9, 2019

📌 Commit 3ba82f7 has been approved by mark-i-m

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2019
This was referenced Jun 9, 2019
Closed
Closed
@bors
Copy link
Collaborator

bors commented Jun 9, 2019

⌛ Testing commit 3ba82f7 with merge e6e60ef...

@bors
Copy link
Collaborator

bors commented Jun 9, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: mark-i-m
Pushing e6e60ef to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 9, 2019
@bors bors merged commit 3ba82f7 into rust-lang:master Jun 9, 2019
@Centril Centril deleted the macro-at-most-once-2015 branch June 9, 2019 07:58
@Centril Centril mentioned this pull request Aug 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-i-m mark-i-m mark-i-m approved these changes

Assignees

@Centril Centril

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.

Extending ? macro repetition to Rust 2015
10 participants
@Centril @rust-highfive @bors @craterbot @michaelwoerister @rfcbot @petrochenkov @mark-i-m @nikomatsakis @rustbot